fix: revert "feat(cli-build): preconnect and modulepreload the CDN sanity module for auto-update studios (#1276)"#1400
Merged
Conversation
Contributor
📦 Bundle Stats —
|
| Metric | Value | vs main (9f50d26) |
|---|---|---|
| Internal (raw) | 2.7 KB | - |
| Internal (gzip) | 1.0 KB | - |
| Bundled (raw) | 11.16 MB | - |
| Bundled (gzip) | 2.10 MB | - |
| Import time | 895ms | -8ms, -0.9% |
bin:sanity
| Metric | Value | vs main (9f50d26) |
|---|---|---|
| Internal (raw) | 782 B | - |
| Internal (gzip) | 423 B | - |
| Bundled (raw) | 9.87 MB | - |
| Bundled (gzip) | 1.78 MB | - |
| Import time | 2.31s | -13ms, -0.6% |
🗺️ View treemap · Artifacts
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
📦 Bundle Stats — @sanity/cli-core
Compared against main (9f50d269)
| Metric | Value | vs main (9f50d26) |
|---|---|---|
| Internal (raw) | 106.7 KB | - |
| Internal (gzip) | 26.7 KB | - |
| Bundled (raw) | 21.72 MB | - |
| Bundled (gzip) | 3.46 MB | - |
| Import time | 808ms | +13ms, +1.6% |
🗺️ View treemap · Artifacts
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
📦 Bundle Stats — create-sanity
Compared against main (9f50d269)
| Metric | Value | vs main (9f50d26) |
|---|---|---|
| Internal (raw) | 908 B | - |
| Internal (gzip) | 483 B | - |
| Bundled (raw) | 931 B | - |
| Bundled (gzip) | 491 B | - |
| Import time | ❌ ChildProcess denied: node | - |
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
bjoerge
approved these changes
Jun 29, 2026
Contributor
Coverage Delta
Comparing 1 changed file against main @ Overall Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This reverts commit 71d4f20.
Auto-updating studios built with this CLI feature completely fail to render in Safari, due to CORS.
Let's revert this optimisation so folks have a path to unblock themselves if they are affected (update CLI and redeploy). We can then take a look at whether preloading can be reimplemented without breaking Safari.
What to review
Reverted code.
Testing
Studios build—sans the preload code—and are able to load in Safari again. Tests pass.
Note
Low Risk
Removes performance hints only; restores prior behavior for timestamped import maps and CSS, with no auth or data-path changes.
Overview
Reverts the auto-update studio HTML injection that added
link[rel="preconnect"]andlink[rel="modulepreload"]for the CDNsanitymodule (PR #1276), because those hints break studio rendering in Safari due to CORS.addTimestampImportMapScriptToHtmlagain only refreshes import-map timestamps and injects timestamped stylesheets; CDN hostname detection for timestamp replacement is inlined inreplaceTimestampinstead of a sharedisSanityCdnUrlhelper. The preconnect/modulepreload unit tests are removed, and@sanity/cli-buildis bumped as a patch in the changeset.Reviewed by Cursor Bugbot for commit e955833. Bugbot is set up for automated code reviews on this repo. Configure here.