Skip to content

feat: publish create-sanity package#235

Merged
binoy14 merged 2 commits into
mainfrom
12-29-feat_publish_create-sanity_package
Dec 31, 2025
Merged

feat: publish create-sanity package#235
binoy14 merged 2 commits into
mainfrom
12-29-feat_publish_create-sanity_package

Conversation

@binoy14
Copy link
Copy Markdown
Contributor

@binoy14 binoy14 commented Dec 30, 2025

TL;DR

Added create-sanity package to the release workflow and configured it for alpha releases.

What changed?

  • Added create-sanity to the publish filter in the release-please workflow
  • Updated the GitHub workflow summary to display package versions in a table format
  • Added create-sanity to the release-please manifest with version 6.0.0-alpha.0
  • Removed create-sanity from the ignored packages in knip configuration
  • Added knip configuration for create-sanity to ignore @sanity/cli dependency
  • Updated create-sanity package version from 3.70.0 to 6.0.0-alpha.0
  • Added release-please configuration for the create-sanity package

Why make this change?

To include the create-sanity package in our automated release process, ensuring it's published alongside other CLI packages with proper versioning and alpha tagging. This aligns the package with our new versioning strategy and makes it part of the automated release pipeline.

@claude
Copy link
Copy Markdown

claude Bot commented Dec 30, 2025

Claude finished @binoy14's task —— View job


PR Review: feat: publish create-sanity package

Todo List:

  • Read and analyze changed files
  • Check for bugs or logic errors
  • Verify security and performance considerations
  • Review configuration changes for correctness
  • Provide actionable feedback

Issues Found:

1. Inconsistent Version Jump (packages/create-sanity/package.json:3)
The version jumps from 3.70.0 to 6.0.0-alpha.0, which is a major version jump. This should align with the other CLI packages that are at 6.0.0-alpha.x for consistency, but the change from a stable version to an alpha prerelease needs verification.

2. Missing Error Handling (.github/workflows/release-please.yml:77)
The GitHub workflow summary uses steps.release.outputs['create-sanity--version'] || 'N/A' but if the release-please action fails to generate the create-sanity version output, this could silently show 'N/A' without indicating a problem.

3. Potential Package Resolution Issue (packages/create-sanity/index.js:11-15)
The moduleResolve call could fail in environments where the workspace dependency resolution doesn't work as expected. The error message is generic and doesn't provide debugging information about the resolution failure.

Recommendation: Add more specific error context:

} catch (err) {
  throw new Error(`Failed to resolve '@sanity/cli' package. Current working directory: ${process.cwd()}. Node version: ${process.version}`, {cause: err})
}

4. Missing Build Verification
The workflow publishes create-sanity but doesn't explicitly build or test the create-sanity package before publishing. While it runs pnpm run build:cli, it's unclear if this covers create-sanity.

Configuration Review:

  • Release-please configuration correctly mirrors other packages
  • Knip configuration appropriately ignores @sanity/cli dependency
  • Workflow filter addition is correct

Copy link
Copy Markdown
Contributor Author

binoy14 commented Dec 30, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 30, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 75.81% 5278 / 6962
🔵 Statements 75% 5406 / 7208
🔵 Functions 65.98% 772 / 1170
🔵 Branches 62.55% 2315 / 3701
File CoverageNo changed files found.
Generated in workflow #1283 for commit 47d8a2a by the Vitest Coverage Report Action

@binoy14 binoy14 marked this pull request as ready for review December 30, 2025 16:40
@binoy14 binoy14 requested a review from a team as a code owner December 30, 2025 16:40
@binoy14 binoy14 requested review from mttdnt and removed request for a team December 30, 2025 16:40
@binoy14 binoy14 force-pushed the 12-29-feat_publish_create-sanity_package branch from 2a52a57 to b79d373 Compare December 30, 2025 20:00
@binoy14 binoy14 force-pushed the 12-29-feat_publish_create-sanity_package branch from b79d373 to 47d8a2a Compare December 30, 2025 20:21
@binoy14 binoy14 merged commit a9b98d4 into main Dec 31, 2025
30 of 34 checks passed
@binoy14 binoy14 deleted the 12-29-feat_publish_create-sanity_package branch December 31, 2025 19:05
@squiggler-legacy squiggler-legacy Bot mentioned this pull request Dec 31, 2025
@squiggler-legacy squiggler-legacy Bot mentioned this pull request Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants