test: test exports match for CLI versions

[binoy14]

Adds a test to compare exports and type exports from current CLI and new CLI to ensure we don't break any exports. The test is currently just logging the changes instead of failing the test

[linear]

SDK-700 Write test to match exports from old CLI with new CLI

[binoy14]

• test: test exports match for CLI versions #315 👈 (View in Graphite)
• chore(build): use pkg-utils to generate types #318
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[claude]

Claude finished @binoy14's task in 57s —— View job

---

Code Review

• Read repository guidelines
• Review test file changes
• Review other file changes
• Provide feedback

---

Issues Found

1. Silent test failure (lines 129-148)
The second test catches assertion errors but swallows them, only logging to console. This defeats the purpose of having a test. Either:

• Remove the try-catch block entirely if you want the test to fail
• Use test.skip() or test.todo() if it's intentionally not enforced yet

2. Unsafe type assertion (line 50 in readPackageJson.ts)
When skipSchemaValidation is true, the code uses as PackageJson without validation. This is used in the test at line 71 where downloaded package.json is read. If the old CLI version has a malformed package.json, it will silently return invalid data and cause cryptic errors downstream.

3. Error property access without check (line 146)
error.expected and error.actual are accessed without verifying they exist. If the error shape is different, this will throw.

4. Missing error type checking (line 44)
error.code is accessed without narrowing the error type. Add proper type guard.

5. Unnecessary dependency
@vitest/utils is added only for the diff function. Consider if this is worth the dependency or if you can use a simpler approach like just logging the arrays directly.

6. Test relies on external network
The test downloads from npm registry (line 51). If npm is down or the package is unpublished, the test fails. Consider mocking or caching this for reliability.

[github-actions]

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	73.82%	5973 / 8091
🔵	Statements	73.13%	6125 / 8375
🔵	Functions	67.25%	908 / 1350
🔵	Branches	61.02%	2654 / 4349

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
packages/@sanity/cli/src/util/readPackageJson.ts	100%	100%	100%	100%

Generated in workflow #1812 for commit d3090d6 by the Vitest Coverage Report Action