perf: speed up graphql commands

[rexxars]

Description

The graphql deploy command currently loads studio config (via Vite), resolves workspaces, then sends serialized schema types back to the main thread — where it compiles schemas and extracts the GraphQL spec sequentially. This PR restructures the pipeline so that schema compilation and extraction happen inside the worker thread, avoiding the round-trip overhead of serializing full schema types across the thread boundary.

Performance: ~15% faster on graphql deploy (measured via wall-clock benchmarks against basic-studio and worst-case-studio fixtures). The gain comes from doing more work in the worker and sending back only the extracted GraphQL spec rather than raw schema types.

Error handling: Schema errors (both from createSchema() and from extractFromSanitySchema()) are now caught per-API instead of failing the entire deployment. If one API has schema errors, the others still get processed and all errors are reported together.

graphql undeploy: Now uses a lightweight metadata-only path (resolveGraphQLApiMetadata) that reads workspace config without compiling schemas at all — it only needs projectId/dataset/tag to identify which API to undeploy.

What to review

• extractGraphQLAPIs.ts / extractGraphQLAPIsWorker.ts — the new worker pipeline that does schema compilation + extraction in-thread. This is the core change.
• resolveGraphQLApisFromWorkspaces.ts — shared workspace/source resolution logic extracted from the old worker, now used by both the full-compile and metadata-only paths.
• deploy.ts — updated to consume pre-extracted GraphQL specs instead of compiling schemas itself. Per-API error handling for schemaErrors and extractionError.
• getGraphQLAPIs.worker.ts — now serves graphql undeploy with a lightweight metadata-only path (no schema compilation).

Testing

• Unit tests for extractGraphQLAPIsWorker (schema extraction, per-API error handling, Symbol serialization)
• Unit tests for resolveGraphQLApisFromWorkspaces (both resolveGraphQLApis and resolveGraphQLApiMetadata — single/multi workspace, source inheritance, validation)
• Unit tests for SchemaError (custom labels, formatted output)
• Deploy command tests for per-API schema errors, extraction errors, warning-only errors, multi-API flag overrides
• Integration test (graphqlAPIs.integration.test.ts) that runs the full extraction pipeline against real schema fixtures

[claude]

Claude finished @rexxars's task in 2m 54s —— View job

---

• Gather context and read changed files
• Check if previous flagged issues are resolved
• Analyze new changes for issues
• Post review findings

---

Review

Issue 1 (empty string projectId/dataset validation) — Fixed ✅
The latest commit (af2ee4b) now correctly rejects empty strings in getGraphQLAPIs.worker.ts:55-59.

---

Issue 2 — resolveLocalPackage and default createSchema outside any try/catch

extractGraphQLAPIs.ts:122-125 — both the package resolution and the empty-schema call are still uncovered:

const {createSchema} = await deps.resolveLocalPackage<typeof import('sanity')>('sanity', workDir)
const defaultSchema = createSchema({name: 'default', types: []})

If resolveLocalPackage throws (version mismatch, missing build), the worker thread dies with a raw uncaught error rather than a structured message. The per-API try/catch loop on line 144 does not protect this setup path.

Fix this →

---

Issue 3 — Multiple unnamed unstable_sources silently collapsed to 'default'

getGraphQLAPIs.worker.ts:105 — unchanged from previous review. Two unstable_sources entries without explicit name fields both receive name: 'default'. resolveWorkspaceAndSource uses .find() so the second entry is silently dropped, producing incorrect undeploy behavior with no error.

Either detect and throw on duplicate names in extractSourceMetadata, or document that unnamed sources are unsupported for the metadata-only path:

// After building sources[], before return:
const names = sources.map((s) => s.name)
const hasDuplicates = names.length !== new Set(names).size
if (hasDuplicates) {
  throw new Error('Multiple unstable_sources without unique names are not supported for graphql undeploy')
}

Fix this →

[github-actions]

Coverage Delta

File	Statements
packages/@sanity/cli/src/actions/graphql/SchemaError.ts	100.0% (+ 100.0%)
packages/@sanity/cli/src/actions/graphql/extractFromSanitySchema.ts	87.0% (- 0.4%)
packages/@sanity/cli/src/actions/graphql/extractGraphQLAPIs.ts	98.0% (new)
packages/@sanity/cli/src/actions/graphql/extractGraphQLAPIs.worker.ts	0.0% (new)
packages/@sanity/cli/src/actions/graphql/gen1/index.ts	100.0% (±0%)
packages/@sanity/cli/src/actions/graphql/gen2/index.ts	100.0% (±0%)
packages/@sanity/cli/src/actions/graphql/gen3/generateTypeQueries.ts	95.8% (±0%)
packages/@sanity/cli/src/actions/graphql/gen3/index.ts	90.9% (- 0.8%)
packages/@sanity/cli/src/actions/graphql/getGraphQLAPIs.ts	100.0% (+ 6.3%)
packages/@sanity/cli/src/actions/graphql/getGraphQLAPIs.worker.ts	0.0% (±0%)
packages/@sanity/cli/src/actions/graphql/helpers.ts	100.0% (±0%)
packages/@sanity/cli/src/actions/graphql/resolveGraphQLApisFromWorkspaces.ts	97.6% (new)
packages/@sanity/cli/src/actions/schema/validateSchema.worker.ts	0.0% (±0%)
packages/@sanity/cli/src/commands/graphql/deploy.ts	91.6% (+ 6.9%)
packages/@sanity/cli/src/commands/graphql/undeploy.ts	100.0% (±0%)
packages/@sanity/cli/src/services/getUrlHeaders.ts	100.0% (±0%)
packages/@sanity/cli/src/util/isSchemaError.ts	100.0% (new)

Comparing 17 changed files against main @ 1f551d2ea701f15feff71e8af72739755179ba03

Overall Coverage

Metric	Coverage
Statements	80.3% (+ 0.6%)
Branches	67.7% (+ 0.9%)
Functions	78.2% (+ 1.0%)
Lines	80.7% (+ 0.6%)

[rexxars]

Claude is going to keep finding issue no matter how far I take this but I'm gonna call this readyish now. Will do a read-through and mark it ready.

[claude]

Claude finished @rexxars's task in 4m 41s —— View job

---

Review

• Gather context
• Read changed files
• Analyze for issues
• Post review findings

---

The three issues flagged in the previous review remain unaddressed after the refactor. Nothing new introduced in the latest commits.

1. Empty string still passes projectId/dataset validation

getGraphQLAPIs.worker.ts:55-62 — toWorkspaceMetadata rejects non-string values but accepts ''. An empty projectId/dataset from defineConfig({projectId: ''}) passes the worker guard and only fails later in resolveGraphQLApiMetadata with a less precise message. The downstream check added in e228a1f (!ws.projectId) catches it, but the guard in the worker should match:

// Current — allows empty string
if (!('projectId' in config) || typeof config.projectId !== 'string') {

// Fix
if (!('projectId' in config) || !config.projectId) {

Same for dataset at lines 59-62.

---

2. createSchema called outside per-API try/catch

extractGraphQLAPIs.ts:148-151 — createSchema is called before the per-API loop. If resolveLocalPackage returns something unexpected (version mismatch, malformed build), this throws a TypeError that propagates uncaught out of extractGraphQLAPIsWorker, crashing the worker thread. The per-API error handling (lines 189-223) does not protect this path.

const {createSchema} = await deps.resolveLocalPackage<typeof import('sanity')>('sanity', workDir)
// Add before line 151:
if (typeof createSchema !== 'function') {
  throw new TypeError('Expected `createSchema` from `sanity` to be a function')
}
const defaultSchema = createSchema({name: 'default', types: []})

---

3. Multiple unnamed unstable_sources silently collapsed to 'default'

getGraphQLAPIs.worker.ts:101-102 — if a user configures two unstable_sources without name fields, both get assigned name: 'default'. resolveWorkspaceAndSource uses .find(), so the second entry is silently ignored, producing incorrect undeploy behavior with no error. Either detect and reject duplicates, or document that unnamed sources are unsupported in this path:

const sourceName =
  'name' in source && typeof source.name === 'string' ? source.name : 'default'
// Two sources without names → both 'default' → second silently dropped

[binoy14]

ah smart, good way to run worker tests 🤔