fix(ci): remove compare-npm to fix bundle-stats timeout#849
Closed
fix(ci): remove compare-npm to fix bundle-stats timeout#849
Conversation
The compare-npm: latest option was causing bundle-stats to fail on all PRs since the v6.3.0 release. The action tries to npm install @sanity/cli@6.3.0 into a temp directory with a 120-second timeout, which is insufficient for the package's dependency tree. The base-branch comparison (head vs base) remains and is the more useful comparison. Also bumps the action from v1.11.0 to v1.11.1. Co-authored-by: Binoy Patel <binoy14@users.noreply.github.com>
Contributor
📦 Bundle Stats —
|
| Metric | Value | vs main (6c351ae) |
|---|---|---|
| Internal (raw) | 2.1 KB | - |
| Internal (gzip) | 799 B | - |
| Bundled (raw) | 11.06 MB | - |
| Bundled (gzip) | 2.07 MB | - |
| Import time | 825ms | -2ms, -0.2% |
bin:sanity
| Metric | Value | vs main (6c351ae) |
|---|---|---|
| Internal (raw) | 975 B | - |
| Internal (gzip) | 460 B | - |
| Bundled (raw) | 9.83 MB | - |
| Bundled (gzip) | 1.77 MB | - |
| Import time | 1.92s | +7ms, +0.4% |
🗺️ View treemap · Artifacts
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
📦 Bundle Stats — @sanity/cli-core
Compared against main (6c351ae1)
| Metric | Value | vs main (6c351ae) |
|---|---|---|
| Internal (raw) | 92.2 KB | - |
| Internal (gzip) | 21.6 KB | - |
| Bundled (raw) | 21.64 MB | - |
| Bundled (gzip) | 3.43 MB | - |
| Import time | 774ms | -4ms, -0.5% |
🗺️ View treemap · Artifacts
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
bundle-statsCI check has been failing on the last 3 PRs (#846, #847, #848) with:Root Cause
The
compare-npm: latestoption in the bundle-stats workflow tells therexxars/bundle-statsaction to install the latest published version of@sanity/clifrom npm into a temp directory usingnpm install. The action has a hardcoded 120-second timeout for this install.Since the v6.3.0 release,
@sanity/cliand its dependency tree are large enough thatnpm installcannot complete within 120 seconds on GitHub Actions runners, causing every PR's bundle-stats check to fail.Earlier PRs (#841, #842) passed because they ran before v6.3.0 was published to npm (or hit a cached/smaller version).
Fix
compare-npm: latest— the base-branch comparison (PR head vs. merge base) is the primary and more useful comparison. The npm comparison was a nice-to-have supplement.rexxars/bundle-statsfrom v1.11.0 to v1.11.1 — picks up a fix for import timing output (write import timing to temp file instead of stdout).