Skip to content

chore: add nextjs-app fixture files#920

Merged
binoy14 merged 1 commit into
mainfrom
chore/add-nextjs-app-fixture
Apr 10, 2026
Merged

chore: add nextjs-app fixture files#920
binoy14 merged 1 commit into
mainfrom
chore/add-nextjs-app-fixture

Conversation

@binoy14
Copy link
Copy Markdown
Contributor

@binoy14 binoy14 commented Apr 10, 2026

Description

Add a minimal Next.js app fixture for use in e2e init tests. These files were copied from #894 to make the fixture available ahead of that PR landing.

Includes:

  • app/layout.tsx and app/page.tsx — minimal App Router components
  • next.config.mjs — empty Next.js config
  • package.json — next 16, react 19, typescript
  • tsconfig.json — standard Next.js TypeScript config

What to review

Verify the fixture files match what's expected in #894 and are sufficient for e2e init tests.

Testing

No automated tests added — this is a test fixture that will be consumed by e2e tests in #894.

🤖 Generated with Claude Code

@claude
Copy link
Copy Markdown

claude Bot commented Apr 10, 2026

Claude finished @binoy14's task in 1m 8s —— View job


Review

  • Gather context
  • Read changed files
  • Check for changeset
  • Post review

Missing changeset

packages/@sanity/cli-test is a published public package ("access": "public"). This PR adds 'nextjs-app' to the exported FixtureName type and DEFAULT_FIXTURES in constants.ts, which is a public API addition. The copy-fixtures.ts script will also bundle the new fixture into the published package. A changeset is required for @sanity/cli-test with a minor bump.

Fix this →

@binoy14 binoy14 force-pushed the chore/add-nextjs-app-fixture branch from 34325ad to 99b85a4 Compare April 10, 2026 16:03
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 10, 2026

📦 Bundle Stats — @sanity/cli

Compared against main (e816a43a)

@sanity/cli

Metric Value vs main (e816a43)
Internal (raw) 2.1 KB -
Internal (gzip) 799 B -
Bundled (raw) 10.95 MB -
Bundled (gzip) 2.06 MB -
Import time 861ms -18ms, -2.0%

bin:sanity

Metric Value vs main (e816a43)
Internal (raw) 975 B -
Internal (gzip) 460 B -
Bundled (raw) 9.84 MB -
Bundled (gzip) 1.77 MB -
Import time 2.05s -16ms, -0.8%

🗺️ View treemap · Artifacts

Details
  • Import time regressions over 10% are flagged with ⚠️
  • Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.

📦 Bundle Stats — @sanity/cli-core

Compared against main (e816a43a)

Metric Value vs main (e816a43)
Internal (raw) 93.1 KB -
Internal (gzip) 21.9 KB -
Bundled (raw) 21.53 MB -
Bundled (gzip) 3.41 MB -
Import time 807ms -2ms, -0.2%

🗺️ View treemap · Artifacts

Details
  • Import time regressions over 10% are flagged with ⚠️
  • Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.

📦 Bundle Stats — create-sanity

Compared against main (e816a43a)

Metric Value vs main (e816a43)
Internal (raw) 976 B -
Internal (gzip) 507 B -
Bundled (raw) 50.7 KB -
Bundled (gzip) 12.6 KB -
Import time ❌ ChildProcess denied: node -
Details
  • Import time regressions over 10% are flagged with ⚠️
  • Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.

@socket-security
Copy link
Copy Markdown

socket-security Bot commented Apr 10, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addednpm/​next@​16.2.26285919770

View full report

@socket-security
Copy link
Copy Markdown

socket-security Bot commented Apr 10, 2026

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn Medium
Install-time scripts: npm sharp during install

Install script: install

Source: node install/check.js || npm run build

From: pnpm-lock.yamlnpm/sharp@0.34.5

ℹ Read more on: This package | This alert | What is an install script?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/sharp@0.34.5. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 10, 2026

Coverage Delta

No covered files changed in this PR.

Overall Coverage

Metric Coverage
Statements 83.0% (±0%)
Branches 73.0% (±0%)
Functions 82.9% (±0%)
Lines 83.5% (±0%)

Add a minimal Next.js app fixture for use in e2e init tests, matching
the fixture from #894. Register it in cli-test constants and knip config.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@binoy14 binoy14 force-pushed the chore/add-nextjs-app-fixture branch from 99b85a4 to 50ac0ff Compare April 10, 2026 16:13
@binoy14 binoy14 marked this pull request as ready for review April 10, 2026 16:44
@binoy14 binoy14 requested a review from a team as a code owner April 10, 2026 16:44
@binoy14 binoy14 requested review from mariuslundgard and mttdnt and removed request for a team April 10, 2026 16:44
@binoy14 binoy14 merged commit 966deae into main Apr 10, 2026
45 checks passed
@binoy14 binoy14 deleted the chore/add-nextjs-app-fixture branch April 10, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants