refactor: simplify diffItem control flow #43
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

This PR refactors the main
diffItemfunction to improve its control flow and readability. The changes make the logic for handling different data type comparisons more explicit and streamlined.Key Changes:
source === targetat the very beginning.aType,bType,aIsUndefined,bIsUndefined,dataType, andisContainerhas been removed.diffItemnow has explicit checks and calls to dedicated handlers for common type pairs:if (typeof source === 'string' && typeof target === 'string')callsdiffString(...).if (Array.isArray(source) && Array.isArray(target))callsdiffArray(...).if (isRecord(source) && isRecord(target))callsdiffObject(...). (IntroducedisRecordtype guard).diffPrimitivefunction. String diffing is now handled bydiffString.target === undefined, anunsetpatch is pushed.setpatch withtargetis pushed.PrimitiveValueType: ThePrimitiveValuetype alias is no longer needed as specific type checks are used.Rationale:
diffString,diffArray, anddiffObjectmakes the intent clearer for these common structured types.aType,bType, etc.) and thediffPrimitivefunction simplifies the overall structure ofdiffItem.This refactoring makes the core diffing logic within
diffItemcleaner and more maintainable.