feat: add support for type prefix #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ascorbic is attempting to deploy a commit to the Sanity Team on Vercel. A member of the Team first needs to authorize it. |
snorrees
approved these changes
Jul 12, 2023
|
|
||
| export function getCacheKey(config: PluginConfig, suffix: CACHE_KEYS) { | ||
| return `${config.projectId}-${config.dataset}-${suffix}` | ||
| return `${config.projectId}-${config.dataset}-${config.typePrefix ?? ''}-${suffix}` |
There was a problem hiding this comment.
Get a double -- here when config.typePrefix is undefined. Since its only a key, I guess it doesnt matter and is rather preferable to a more messy string template.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
🎉 This PR is included in version 7.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for setting a custom type prefix, which allows multiple instances of the plugin to be used. The prefix is in addition to the
Sanityprefix, so for example if you have amoviestype, setting the type prefix toStagingwill make the typeStagingSanityMovies.