fix(internationalized-array): resolve TypeScript lint errors in test files#544
Merged
pedrobonamin merged 2 commits intofeat/internationalized-array-testsfrom Feb 4, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
- Replace dot notation with bracket notation for index signature properties (_key, _type) - Add type guards for validation rule extraction - Use proper type narrowing instead of unsafe type assertions - Add ValidationResult type for better type safety in tests - Suppress TypeScript errors for test mock implementations with @ts-expect-error - Add type guards in test assertions to properly narrow union types Co-authored-by: pedrobonamin <46196328+pedrobonamin@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add comprehensive test suite for _key migration
fix(internationalized-array): resolve TypeScript lint errors in test files
Feb 4, 2026
21f1579
into
feat/internationalized-array-tests
8 checks passed
pedrobonamin
added a commit
that referenced
this pull request
Feb 4, 2026
…files (#544) * Initial plan * fix(internationalized-array): resolve lint errors in test files - Replace dot notation with bracket notation for index signature properties (_key, _type) - Add type guards for validation rule extraction - Use proper type narrowing instead of unsafe type assertions - Add ValidationResult type for better type safety in tests - Suppress TypeScript errors for test mock implementations with @ts-expect-error - Add type guards in test assertions to properly narrow union types Co-authored-by: pedrobonamin <46196328+pedrobonamin@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: pedrobonamin <46196328+pedrobonamin@users.noreply.github.com>
pedrobonamin
added a commit
that referenced
this pull request
Feb 5, 2026
…files (#544) * Initial plan * fix(internationalized-array): resolve lint errors in test files - Replace dot notation with bracket notation for index signature properties (_key, _type) - Add type guards for validation rule extraction - Use proper type narrowing instead of unsafe type assertions - Add ValidationResult type for better type safety in tests - Suppress TypeScript errors for test mock implementations with @ts-expect-error - Add type guards in test assertions to properly narrow union types Co-authored-by: pedrobonamin <46196328+pedrobonamin@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: pedrobonamin <46196328+pedrobonamin@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test suite had 15 TypeScript lint errors preventing CI from passing. All errors were in test files and related to type safety issues with mocks and assertions.
Changes
item._keytoitem['_key']for properties accessed via index signatures (TS4111)ValidationResultunion type and type narrowing for test assertions:@ts-expect-errorfor intentional mock implementations that deviate from production typesAll 114 tests pass with 0 lint errors.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.