Skip to content

Import MAX_COLUMNS from constants instead of duplicating in test#549

Merged
pedrobonamin merged 2 commits intofeat/internationalized-array-testsfrom
copilot/sub-pr-542
Feb 4, 2026
Merged

Import MAX_COLUMNS from constants instead of duplicating in test#549
pedrobonamin merged 2 commits intofeat/internationalized-array-testsfrom
copilot/sub-pr-542

Conversation

Copy link
Contributor

Copilot AI commented Feb 4, 2026

The AddButtons.test.ts file duplicated the MAX_COLUMNS constant instead of importing it from constants.ts. If the actual values change, tests would pass against stale hardcoded values.

Changes:

  • Import MAX_COLUMNS from ../constants
  • Remove duplicated constant definition
 import {describe, expect, it} from 'vitest'
 
 import {createValues, testLanguages} from '../__tests__/test-utils'
+import {MAX_COLUMNS} from '../constants'

-const MAX_COLUMNS = {
-  codeOnly: 5,
-  titleOnly: 4,
-  titleAndCode: 3,
-}

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@vercel
Copy link

vercel bot commented Feb 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
plugins-studio Ready Ready Preview, Comment Feb 4, 2026 2:36pm

Request Review

@changeset-bot
Copy link

changeset-bot bot commented Feb 4, 2026

⚠️ No Changeset found

Latest commit: 2da8ed1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Co-authored-by: pedrobonamin <46196328+pedrobonamin@users.noreply.github.com>
Copilot AI changed the title [WIP] WIP Address feedback on test suite for key migration Import MAX_COLUMNS from constants instead of duplicating in test Feb 4, 2026
Copilot AI requested a review from pedrobonamin February 4, 2026 14:38
@pedrobonamin pedrobonamin marked this pull request as ready for review February 4, 2026 14:38
@pedrobonamin pedrobonamin merged commit 65ba697 into feat/internationalized-array-tests Feb 4, 2026
8 checks passed
@pedrobonamin pedrobonamin deleted the copilot/sub-pr-542 branch February 4, 2026 14:38
pedrobonamin added a commit that referenced this pull request Feb 4, 2026
* Initial plan

* fix: import MAX_COLUMNS from constants instead of duplicating

Co-authored-by: pedrobonamin <46196328+pedrobonamin@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: pedrobonamin <46196328+pedrobonamin@users.noreply.github.com>
pedrobonamin added a commit that referenced this pull request Feb 5, 2026
* Initial plan

* fix: import MAX_COLUMNS from constants instead of duplicating

Co-authored-by: pedrobonamin <46196328+pedrobonamin@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: pedrobonamin <46196328+pedrobonamin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants