Update NoNestedIfStatementsRule to flag assignment + if pattern#28
Merged
Update NoNestedIfStatementsRule to flag assignment + if pattern#28
Conversation
Expand the rule to detect nested if statements in two cases:
1. Existing: if contains exactly one nested if statement
2. New: if contains exactly one assignment followed by one if statement
This catches patterns like:
if (condition) {
$var = getValue();
if ($var \!== null) {
// ...
}
}
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Nested if statements with elseif branches can still be converted to guard clauses:
Before:
if ($outer) {
if ($inner) { /* A */ } elseif ($other) { /* B */ }
}
After:
if (\!$outer) return;
if ($inner) { /* A */ } elseif ($other) { /* B */ }
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expand the rule to detect nested if statements in two cases:
This catches patterns like: