Skip to content

Conversation

@newkit
Copy link
Member

@newkit newkit commented Jun 24, 2025

Updated sap_vm_provision(kubevirt_vm)
- Added assert for kubeconfig
- Unified storageclass to sapstorage for both trident and hpp and make configurable
- trident: make parameters configurable in role - Renamed default namespace for VMs to sap
- Define public ssh key explicitly - fixed network config cloudinit
- added sap_vm_provision_host_specification_plan to sample var file
- make disk access_modes configurable
- make CPU performance settings configurable

Deprecated vars

    -sap_vm_provision_kubevirt_vm_guest_ssh_auth_mechanism
    -sap_vm_provision_kubevirt_vm_extract_kubeconfig
    -sap_vm_provision_kubevirt_vm_kubeconfig_path
    -sap_vm_provision_kubevirt_vm_ca_cert
    -sap_vm_provision_kubevirt_vm_api_endpoint
    -sap_vm_provision_kubevirt_vm_admin_username
    -sap_vm_provision_kubevirt_vm_admin_password

    - sap_vm_provision(kubevirt_vm)
        - Added assert for kubeconfig
        - Unified storageclass to sapstorage for both trident and hpp and
          make configurable
        - trident: make parameters configurable in role
        - Renamed default namespace for VMs to sap
        - Define public ssh key explicitly
        - fixed network config cloudinit
        - added sap_vm_provision_host_specification_plan to sample var file
        - make disk access_modes configurable
        - make CPU performance settings configurable
@newkit newkit self-assigned this Jun 25, 2025
@newkit newkit requested review from geetikakay June 26, 2025 13:33
@marcelmamula marcelmamula self-requested a review July 3, 2025 11:57
@marcelmamula
Copy link
Contributor

@newkit Please make sure to run ansible-lint before commits as I can see errors still.

  • wrong indents and spaces
  • missing FQCN for assert
yaml[indentation]: Wrong indentation: expected 8 but found 9
playbooks/sample-sap-vm-provision-redhat-ocpv.yml:36

fqcn[action-core]: Use FQCN for builtin module actions (assert).
playbooks/sample-sap-vm-provision-redhat-ocpv.yml:38 Use `ansible.builtin.assert` or `ansible.legacy.assert` instead.

yaml[trailing-spaces]: Trailing spaces
playbooks/vars/sample-variables-sap-vm-provision-redhat-ocpv.yml:21

@newkit
Copy link
Member Author

newkit commented Jul 16, 2025

Linter issues are fixed and deprecated vars are added to initial commit message.

@marcelmamula
Copy link
Contributor

Linter issues are fixed and deprecated vars are added to initial commit message.

Please confirm when both PRs are ready for review after all these changes.

@newkit
Copy link
Member Author

newkit commented Jul 17, 2025

With the latest code all my CI tests are successful now.

@newkit newkit requested a review from marcelmamula July 17, 2025 07:55
Copy link
Contributor

@marcelmamula marcelmamula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me from linting and code review perspective.
I am unable to test this change myself.

@newkit newkit merged commit dc197b9 into sap-linuxlab:dev Jul 22, 2025
3 checks passed
@marcelmamula marcelmamula changed the title Updated sap_vm_provision(kubevirt_vm) sap_vm_provision: Updated kubevirt_vm Aug 12, 2025
@newkit newkit deleted the feature_update_sap_vm_provision branch September 1, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants