my fix to issue#30

[crweller]

see my comment on issue#30

Start/stop SAP instances in the right order.

[rhmk]

LGTM

[marcelmamula]

LGTM.

Consider cutting down line length in future if you repeat some code like this.

- name: Prepare - Sort sap_facts_register by sap_control_instance_type_sortorder
  ansible.builtin.set_fact:
    sorted_sap_facts: "{{ (sorted_sap_facts | default([]) | unique) + ( __type_list | difference(sorted_sap_facts | default([]))) }}"
  loop: "{{ sap_control_instance_type_sortorder | reverse if funct_type == 'stop' else sap_control_instance_type_sortorder }}"
  vars:
    __type_list: "{{ sap_facts_register.ansible_facts.sap | selectattr('TYPE', 'equalto', item) | list }}"
  when: 
    - __type_list | length > 0

[crweller]

Thanks, will do.

[sean-freeman]

@crweller AAS?

[crweller]

@sean-freeman The sap_libs/sap_system_facts module does not contain a type AAS.
Only the types listed here are returned.
Reason is, that the services, which are used to identify the type, are the same on all application servers regardless of the naming as AAS or PAS.