Skip to content

[as3] display AS3 version on device connection#697

Merged
notandy merged 1 commit intomainfrom
as3-info
Mar 19, 2026
Merged

[as3] display AS3 version on device connection#697
notandy merged 1 commit intomainfrom
as3-info

Conversation

@notandy
Copy link
Collaborator

@notandy notandy commented Mar 18, 2026

makes easier to see if AS3 is available on the device in case AS3 stops
working.

makes easier to see if AS3 is available on the device in case AS3 stops
working.
@notandy notandy requested review from a team, m-kratochvil, notque and ronchi-oss as code owners March 18, 2026 20:14
@github-actions
Copy link

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/sapcc/archer/internal/agent/f5/as3 85.23% (ø)
github.com/sapcc/archer/internal/agent/f5/bigip 8.00% (-0.57%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/sapcc/archer/internal/agent/f5/as3/as3types.go 72.97% (ø) 333 243 90
github.com/sapcc/archer/internal/agent/f5/bigip/bigip.go 9.14% (-0.75%) 197 (+15) 18 179 (+15) 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Copy link
Contributor

@m-kratochvil m-kratochvil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks!

@notandy notandy merged commit 52a6f23 into main Mar 19, 2026
6 checks passed
@notandy notandy deleted the as3-info branch March 19, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants