Skip to content

Conversation

@groenroos
Copy link
Member

Standardises the various redirection points into a single Redirect lib, and implement variable interpolation as per #299.

Additionally, fixes some query parameter related stuff.

Closes #299.

@groenroos groenroos added the feature Brand new features to Sapling label Oct 25, 2021
@groenroos groenroos added this to the M2 - Release 2.0 milestone Oct 25, 2021
@groenroos groenroos self-assigned this Oct 25, 2021
@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #322 (f04f141) into master (67515b9) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #322      +/-   ##
==========================================
+ Coverage   98.21%   98.24%   +0.03%     
==========================================
  Files          36       37       +1     
  Lines        4416     4450      +34     
==========================================
+ Hits         4337     4372      +35     
+ Misses         79       78       -1     
Impacted Files Coverage Δ
hooks/sapling/user/forgot.js 100.00% <100.00%> (ø)
hooks/sapling/user/login.js 100.00% <100.00%> (ø)
hooks/sapling/user/logout.js 100.00% <100.00%> (ø)
hooks/sapling/user/recover.js 100.00% <100.00%> (ø)
hooks/sapling/user/register.js 98.09% <100.00%> (-0.02%) ⬇️
hooks/sapling/user/update.js 100.00% <100.00%> (ø)
lib/Redirect.js 100.00% <100.00%> (ø)
lib/Request.js 99.26% <100.00%> (+0.33%) ⬆️
lib/Response.js 98.50% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67515b9...f04f141. Read the comment docs.

@groenroos groenroos merged commit 44cca73 into master Oct 25, 2021
@groenroos groenroos deleted the feature/redirect-interpolation branch October 25, 2021 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Brand new features to Sapling

Development

Successfully merging this pull request may close these issues.

Variable interpolation in redirect

2 participants