Delete local channelfiles after deleting channel#101
Merged
onnozweers merged 1 commit intomasterfrom Jul 3, 2025
Merged
Conversation
onnozweers
approved these changes
Jul 3, 2025
Contributor
onnozweers
left a comment
onnozweers
left a comment
There was a problem hiding this comment.
Looks good!
Just wondering though, what will happen when the curl fails, and the channel is not really deleted from dCache, but the local info is deleted. By removing all local channel info, you can not find the channel again. Not sure if that is a problem, because dCache should also clean up a channel when its lifetime has expired.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The local files
channel-name-${channel_id}andchannel-status-${channel_id}should be cleaned up after the channel is deleted.