Define fallback value for --version option#38
Merged
hailihu merged 1 commit intosara-nl:masterfrom Nov 29, 2024
Merged
Conversation
The `--version` option relies on `git describe` command to determine the software version. This requires the script to be located within a valid git repository, which may not always be the case. This patch tries to determine the software version using git and adds a fallback value (`unknown`) in case this is not possible. Using the variable `_VERSION_PLACEHOLDER` allows third party tools such as Ansible to edit this specific line with the proper version at the time of deployment.
hailihu
reviewed
Nov 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
--versionoption relies ongit describecommand to determine the software version. This requires the script to be located within a valid git repository, which may not always be the case.This patch tries to determine the software version using git and adds a fallback value (
unknown) in case this is not possible.Using the variable
_VERSION_PLACEHOLDERallows third party tools such as Ansible to edit this specific line with the proper version at the time of deployment.