Merged
Conversation
onnozweers
reviewed
Feb 18, 2025
Contributor
There was a problem hiding this comment.
Hi Haili,
Two comments:
- "dcachetest" turned back to "dolphin12" in the example ada.conf
- In the help text, you refer to
./etc/ada.conf..in Linux means "the current working directory" and not the directory where the ada executable is stored. So, to avoid confusion, I'd like to suggest to rephrase this and perhaps use<scriptdir>/etc/ada.confor{scriptdir}/etc/ada.confas an alternative in the helptext.
Contributor
Author
Thanks, done. |
Contributor
|
Thanks! Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tell Ada to look for an ada.conf in the same dir as where the script is (last in order of preference after /etc/ada.conf and ~/.ada/ada.conf).
Not that $debug is always false when ada.conf is sourced, because the env variables and commandline arguments are set later. So I removed the line: