Fail early when token is about to expire#66
Merged
Conversation
* Fail when token will expire in 10 seconds * Fail when token will expire in 60 seconds, when --recursive was specified * Fix date command for MacOS; added -u to assume UTC instead of local time * Don't validate token when command is "--viewtoken", because we want to view tokens that are invalid.
The illegal byte sequence was in the macaroon's signature. But we filter out the signature anyway. So now we filter out the signature before piping through tr.
hailihu
reviewed
Feb 20, 2025
Contributor
hailihu
left a comment
hailihu
left a comment
There was a problem hiding this comment.
Looks good, some minor comments.
Instead of sometimes 60 and sometimes 10
It wasn't me Damn autocorrect
hailihu
approved these changes
Feb 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--recursivewas specifieddatecommand for MacOS; added -u to assume UTC instead of local time--viewtoken, because we want to view tokens that are invalid.tr: Illegal byte sequence