Skip to content

Use grep with --text to avoid "Binary file" message#83

Merged
hailihu merged 1 commit intomasterfrom
80-some-macaroons-may-cause-binary-file-standard-input-matches
Apr 9, 2025
Merged

Use grep with --text to avoid "Binary file" message#83
hailihu merged 1 commit intomasterfrom
80-some-macaroons-may-cause-binary-file-standard-input-matches

Conversation

@onnozweers
Copy link
Contributor

No description provided.

@onnozweers onnozweers requested a review from hailihu April 8, 2025 15:16
@onnozweers onnozweers linked an issue Apr 8, 2025 that may be closed by this pull request
@hailihu
Copy link
Contributor

hailihu commented Apr 9, 2025

I cannot test it because I don't have that kind of macaroon file, but the change looks good to me.

@hailihu hailihu merged commit 650d989 into master Apr 9, 2025
1 check passed
@onnozweers
Copy link
Contributor Author

Thanks Haili!

@onnozweers onnozweers deleted the 80-some-macaroons-may-cause-binary-file-standard-input-matches branch April 10, 2025 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some macaroons may cause "Binary file" message

2 participants