Add a couple of reference links and solving a conflict#5
Merged
Conversation
saradufour
requested changes
Mar 28, 2025
Owner
saradufour
left a comment
saradufour
left a comment
There was a problem hiding this comment.
Good job but I want you to make some changes because I want to learn how this request is done.
Collaborator
Author
|
Changes made. |
saradufour
requested changes
Mar 28, 2025
Owner
saradufour
left a comment
saradufour
left a comment
There was a problem hiding this comment.
I see a double reference. Maybe you can adjust that?
leenput
approved these changes
Mar 28, 2025
Collaborator
leenput
left a comment
leenput
left a comment
There was a problem hiding this comment.
I made some changes and approve as it is. Can you double check?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #4
Added a couple of GitHub links and solving a self made issue with main branch.