Avoid mutating typed dictionaries during restore#461
Merged
Conversation
burnettk
approved these changes
Apr 28, 2026
Contributor
|
I disagree that removing the typename is a big deal, but again, whatever. At least this is a neutral change rather that the other crap I've felt forced to merge. |
burnettk
approved these changes
Apr 28, 2026
|
|
||
| from functools import partial | ||
|
|
||
| _JSON_PRIMITIVE_TYPES = {str, int, float, bool, type(None)} |
Contributor
There was a problem hiding this comment.
i've seen these _UNDERSCORE_CONSTANTS elsewhere from agents. is there some method to this madness? it's being used in the same file?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change fixes a side effect in
DictionaryConverter.restore()when restoring typed dictionaries.Previously, if the input dict contained a
typename,restore()removed that key from the original input viapop(). That meant callers could get their source data mutated during deserialization.This update changes
restore()to:typenamewithout mutating the original inputIt also includes a small cleanup in
restore()for JSON primitive values and common container types.Why
Deserializer helpers should not mutate caller-owned input data. That behavior is surprising, can make debugging
harder, and can break reuse of the same serialized structure across multiple restore calls or assertions.
Test Plan
uv run python -m unittest -v tests.SpiffWorkflow.bpmn.serializer.DictionaryConverterTest