test(server): close race in MockProvider mock-message access#98
Draft
miotte wants to merge 1 commit into
Draft
Conversation
The package-level mockp is shared across tests, and Subscribe runs in a goroutine that defers a 500ms sleep before returning. That goroutine can outlive the test that triggered it, so its read/reset of MockMessages races against the next test's Subscribe goroutine when -race is enabled. Encapsulate the slice behind a sync.Mutex with SetMockMessages and takeMockMessages helpers, and drop the in-Subscribe reassignment in favor of the take semantics. Signed-off-by: Michael Otteni <MichaelGOtteni@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #96
Summary
MockProvider.MockMessagesbehind async.MutexwithSetMockMessagesandtakeMockMessageshelpers.Subscribereassignment in favor of take semantics, so aSubscribegoroutine that outlives its test can no longer race the next test's setup.Test plan
go test ./internal/server/... -race -count=10