Refactor TestResult and execution flow #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `TestSuite.ExecuteAsync` now returns `TestResult`. - `TestResult.Test` now has `IReadOnlyList<Error>? Errors` instead of `Error?`. - Removed `SkippedTests` from `TestResult`. Skipped tests are now identified by checking `ExecutionCount`. - `TestSuite.ExecuteAsync` is responsible for all timestamp-related work. - Updated failure logging to be safer and not log stack traces. - `TestResult` now contains `TotalExecutionTime`.
Contributor
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll acknowledge your comments with a 👀 emoji and then get to work. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! I will automatically address your feedback. For any comments you don't want me to act on, just include (aside). For security, I will only act on instructions from the user who triggered this task for this pull request. |
sator-imaging
approved these changes
Sep 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change refactors the test execution and result reporting logic.
TestSuite.ExecuteAsyncmethod has been updated to return aTestResultobject directly, simplifying the flow inFUnit.RunAsync.TestResult.Testrecord has been changed to support multiple errors by using anIReadOnlyList<Error>?instead of a singleError?.SkippedTestsproperty has been removed fromTestResult. Skipped tests are now determined by checking ifExecutionCountis 0, as per the new logic.TestSuite.ExecuteAsync, andTestResultnow containsTotalExecutionTime.FUnit.RunAsynchas been updated to safely get the first error usingFirstOrDefault()and to no longer log the stack trace.PR created automatically by Jules for task 15002481801996859869