test: improve coverage and fix typecheck for test files#30
Merged
satoshai-dev merged 1 commit intomainfrom Feb 24, 2026
Merged
Conversation
- add tsconfig.check.json so tsc --noEmit typechecks test files - rewrite cli.test.ts to properly test fetchCommand (stdout TS/JSON, invalid format) - add fetcher tests: devnet URL, custom URL, network errors, malformed JSON - tests go from 26 to 31 Closes #5, closes #7, closes #15 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
satoshai-dev
force-pushed
the
fix/test-coverage-and-typecheck
branch
from
aba61aa to
eccb455
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tsconfig.check.jsonsotsc --noEmitnow typechecks test filescli.test.tsto properly testfetchCommand(stdout TS/JSON output, invalid format)Closes #5, closes #7, closes #15
Test plan
pnpm buildpassespnpm test— 31 tests passpnpm typecheck— clean (now includes test files)pnpm lint— clean🤖 Generated with Claude Code