refactor(seeder): remove environment check from DatabaseSeeder and fi…#42
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to improve developer/testing ergonomics by (1) changing the default database seeding behavior for the Auth module and (2) reducing potential E2E test flakiness by avoiding parallel execution for the Magic Link config suite.
Changes:
- Removed the environment guard from
DatabaseSeedersoAuthDatabaseSeederis invoked unconditionally. - Changed the “Magic Link Config” E2E test suite from
test.describe.parallel(...)totest.describe(...)(serial execution by default).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/e2e/tests/magic-link/magic-link.config.spec.ts | Runs the Magic Link config E2E tests non-parallel to reduce shared-state/race issues. |
| database/seeders/DatabaseSeeder.php | Makes Auth module seeding run regardless of environment (but currently introduces a production security risk due to what it seeds). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
9
to
11
| public function run(): void | ||
| { | ||
| if (! app()->environment(['local', 'testing'])) { | ||
| return; | ||
| } | ||
|
|
||
| $this->call(AuthDatabaseSeeder::class); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes minor updates focused on improving the development and testing experience. The main changes are the removal of an environment check in the database seeder and the adjustment of test execution mode for magic link configuration tests.
Database seeding changes:
DatabaseSeederso thatAuthDatabaseSeederis always called, regardless of the environment. This means seeders will run in all environments, not justlocalortesting.Testing changes:
Magic Link Configtest suite to run serially instead of in parallel, which may help avoid race conditions or shared state issues during test execution.