Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for toggling SSL (HTTPS) when setting up the Docker environment, allowing users to choose between SSL-enabled and non-SSL Docker setups. The implementation updates the
.envfile logic, adds a non-SSL Nginx config, and includes comprehensive test coverage for both SSL and non-SSL scenarios.Docker SSL/HTTPS Toggle Support
Feature: SSL Enable/Disable Prompt
mkcertis missing, the setup fails with an instructive error. [1] [2] [3]Configuration: Nginx and .env Adjustments
nginx-no-ssl.confis used instead of the SSL-enabled config..envfile logic is updated so thatAPP_URLis set tohttps://localhostwhen SSL is enabled andhttp://localhostotherwise, while preserving custom URLs. [1] [2]Testing Improvements
.envURL changes, and fallback logic. [1] [2] [3] [4] [5] [6] [7]These changes make the Docker environment setup more flexible and robust, supporting both secure (HTTPS) and simpler (HTTP) local development workflows.