Skip to content

Sonar code smell#374

Merged
sceiler merged 30 commits intomasterfrom
sonar-code-smell
May 5, 2023
Merged

Sonar code smell#374
sceiler merged 30 commits intomasterfrom
sonar-code-smell

Conversation

@sceiler
Copy link
Copy Markdown
Contributor

@sceiler sceiler commented May 5, 2023

Description

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (change which improves current code base; please describe the change)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Screenshots (if appropriate):

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • All new and existing tests passed locally
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

sceiler and others added 30 commits May 5, 2023 21:37
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #374 (871f187) into master (8134802) will decrease coverage by 0.13%.
The diff coverage is 27.58%.

@@             Coverage Diff              @@
##             master     #374      +/-   ##
============================================
- Coverage     39.29%   39.17%   -0.13%     
- Complexity      118      119       +1     
============================================
  Files            23       23              
  Lines           771      776       +5     
  Branches         53       54       +1     
============================================
+ Hits            303      304       +1     
- Misses          449      453       +4     
  Partials         19       19              
Flag Coverage Δ
tests 39.17% <27.58%> (-0.13%) ⬇️
unittests 39.17% <27.58%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../java/com/saucelabs/saucerest/ErrorExplainers.java 34.61% <0.00%> (-1.39%) ⬇️
.../com/saucelabs/saucerest/api/AccountsEndpoint.java 12.30% <0.00%> (ø)
...java/com/saucelabs/saucerest/api/JobsEndpoint.java 10.00% <0.00%> (+0.12%) ⬆️
...a/com/saucelabs/saucerest/api/ResponseHandler.java 33.33% <0.00%> (-0.96%) ⬇️
...a/com/saucelabs/saucerest/api/StorageEndpoint.java 15.51% <25.00%> (+0.97%) ⬆️
.../com/saucelabs/saucerest/api/AbstractEndpoint.java 36.30% <57.14%> (ø)
...va/com/saucelabs/saucerest/SauceShareableLink.java 65.62% <60.00%> (-2.12%) ⬇️

@sceiler sceiler merged commit 1e58a4d into master May 5, 2023
@sceiler sceiler deleted the sonar-code-smell branch May 5, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants