Switch junit to test scope

[timja]

Description

I was surprised when I updated this library in jenkinsci/sauce-ondemand-plugin#118 to get a conflict with junit versions. I assume this is an accident

Motivation and Context

How Has This Been Tested?

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Refactoring (change which improves current code base; please describe the change)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation Update (if none of the other choices apply)

Screenshots (if appropriate):

Checklist

• I have read the CONTRIBUTING doc
• I have added tests that prove my fix is effective or that my feature works
• All new and existing tests passed locally
• I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

[sceiler]

lgtm

[sceiler]

I have rolled this back. Both dependencies are required in the main project and setting it to test scope will break other code. Try it yourself and you will see compiler errors.

[timja]

I see there's a junit extension in this library.

I tried to switch it to the API only but there's something using an internal extension from the engine as well.

saucerest-java/src/main/java/com/saucelabs/saucerest/AfterBeforeParameterResolver.java

Lines 9 to 10 in 8b40533

	import org.junit.jupiter.engine.execution.BeforeEachMethodAdapter;
	import org.junit.jupiter.engine.extension.ExtensionRegistry;

Bit surprising

[sceiler]

iirc I added this because JUnit 5 had some limitations in regards of parameter resolution in test cases.