Skip to content

Platform endpoints do not need auth.#441

Merged
diemol merged 4 commits intomasterfrom
platform-endpoints-no-auth
Oct 18, 2023
Merged

Platform endpoints do not need auth.#441
diemol merged 4 commits intomasterfrom
platform-endpoints-no-auth

Conversation

@diemol
Copy link
Copy Markdown
Member

@diemol diemol commented Oct 17, 2023

This should help CI Sauce to work properly again.

Description

The idea is to have a flag that avoids checking for credentials when interacting with the platform endpoints.

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (change which improves current code base; please describe the change)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Screenshots (if appropriate):

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • All new and existing tests passed locally
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 17, 2023

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 36.48%. Comparing base (22ac60c) to head (6a96507).

Files with missing lines Patch % Lines
.../com/saucelabs/saucerest/api/AbstractEndpoint.java 92.30% 0 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (22ac60c) and HEAD (6a96507). Click for more details.

HEAD has 8 uploads less than BASE
Flag BASE (22ac60c) HEAD (6a96507)
unittests 3 1
tests 5 1
integrationtests 2 0
Additional details and impacted files
@@              Coverage Diff              @@
##             master     #441       +/-   ##
=============================================
- Coverage     75.71%   36.48%   -39.24%     
+ Complexity      264      122      -142     
=============================================
  Files            25       25               
  Lines           869      877        +8     
  Branches         63       65        +2     
=============================================
- Hits            658      320      -338     
- Misses          163      537      +374     
+ Partials         48       20       -28     
Flag Coverage Δ
integrationtests ?
tests 36.48% <94.44%> (-39.24%) ⬇️
unittests 36.48% <94.44%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@diemol
Copy link
Copy Markdown
Member Author

diemol commented Oct 18, 2023

I am not sure why the coverage has changed so much, when I run tests locally, it looks different. I will work on that later. Probably set the tooling again since I cannot change the settings in Codecov.

@diemol diemol merged commit b4b1255 into master Oct 18, 2023
@diemol diemol deleted the platform-endpoints-no-auth branch October 18, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants