Skip to content

Change scope of JUnit dependencies to test#445

Merged
diemol merged 1 commit intosaucelabs:mainfrom
valfirst:change-scope-of-junit-dependencies-to-test
Oct 20, 2023
Merged

Change scope of JUnit dependencies to test#445
diemol merged 1 commit intosaucelabs:mainfrom
valfirst:change-scope-of-junit-dependencies-to-test

Conversation

@valfirst
Copy link
Copy Markdown
Contributor

Description

JUnit dependencies are required for tests only. Previously there were classes requiring JUnit, but they were removed in https://github.com/saucelabs/saucerest-java/pull/443/files.

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (change which improves current code base; please describe the change)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Screenshots (if appropriate):

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • All new and existing tests passed locally
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Copy Markdown
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @valfirst!

@diemol diemol merged commit cacec1c into saucelabs:main Oct 20, 2023
@valfirst valfirst deleted the change-scope-of-junit-dependencies-to-test branch October 20, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants