Switch from logging framework Log4J2 to logging facade SLF4J#447
Merged
diemol merged 1 commit intosaucelabs:valfirstlet-users-choose-logging-frameworkfrom Oct 26, 2023
Conversation
diemol
reviewed
Oct 25, 2023
Member
diemol
left a comment
diemol
left a comment
There was a problem hiding this comment.
Why don't we remove it completely?
Contributor
Author
Not sure what "it" means here. If the question is about Log4J2, it was moved to be used in unit tests only. If it's needed, I can remove Log4J completely and use some simple provider like |
Member
Yes, that is what I meant. Removing Log4J2 completely. |
valfirst
force-pushed
the
let-users-choose-logging-framework
branch
from
2f2955d to
4666bfd
Compare
valfirst
force-pushed
the
let-users-choose-logging-framework
branch
from
4666bfd to
4b113fa
Compare
diemol
approved these changes
Oct 26, 2023
diemol
changed the base branch from
main
to
valfirstlet-users-choose-logging-framework
diemol
added a commit
that referenced
this pull request
Oct 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
saucerest-javais a client for SauceLabs API (library). In other words it can't be used as a standalone application, it's used as dependency for other libraries and applications. That's whysaucerest-javashouldn't have tight coupling with any logging framework and shouldn't have any hardcoded logging configuration (which may bring collisions to users).Motivation and Context
The problem was introduced in this commit: a989460.
saucerest-javashould:How Has This Been Tested?
Types of changes
Screenshots (if appropriate):
Checklist
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...