Skip to content

Add bulk getJobDetails()#452

Merged
diemol merged 3 commits intomainfrom
alexh-add-job-details
Oct 25, 2023
Merged

Add bulk getJobDetails()#452
diemol merged 3 commits intomainfrom
alexh-add-job-details

Conversation

@diemol
Copy link
Copy Markdown
Member

@diemol diemol commented Oct 25, 2023

Description

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (change which improves current code base; please describe the change)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Screenshots (if appropriate):

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • All new and existing tests passed locally
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 25, 2023

Codecov Report

Merging #452 (89c34a6) into main (5a8ec92) will decrease coverage by 36.10%.
The diff coverage is 0.00%.

❗ Current head 89c34a6 differs from pull request most recent head 1f2d083. Consider uploading reports for the commit 1f2d083 to get more accurate results

@@              Coverage Diff              @@
##               main     #452       +/-   ##
=============================================
- Coverage     75.92%   39.83%   -36.10%     
+ Complexity      272      132      -140     
=============================================
  Files            24       24               
  Lines           968      974        +6     
  Branches         68       69        +1     
=============================================
- Hits            735      388      -347     
- Misses          182      563      +381     
+ Partials         51       23       -28     
Flag Coverage Δ
integrationtests ?
tests 39.83% <0.00%> (-36.10%) ⬇️
unittests 39.83% <0.00%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...java/com/saucelabs/saucerest/api/JobsEndpoint.java 9.30% <0.00%> (-79.45%) ⬇️

... and 11 files with indirect coverage changes

@diemol diemol merged commit 2425c57 into main Oct 25, 2023
@diemol diemol deleted the alexh-add-job-details branch October 25, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants