fix: add close button to settings page (#417)#419
Merged
sauravpanda merged 1 commit intomainfrom Apr 15, 2026
Merged
Conversation
The Settings tab is rendered as a full-page view but had no visible way to dismiss it — users had to fall back on the command palette or the keyboard shortcut. Add an absolutely-positioned X button in the top-right corner that calls back to App.tsx to clear showSettings.
sauravpanda
force-pushed
the
Fix-github-tickets
branch
from
ce9921a to
d3f9962
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onClosefromApp.tsxso clicking it returns to the previous viewWhy
SettingsTabrenders as a full-page view (replacing the workspace), but there was no in-UI affordance to dismiss it — users had to know the command palette entry or the Esc shortcut. The new button mirrors the pattern already in place onSettingsPage.tsx.Test plan