Skip to content

Comments

save-cli: Precision and recall#395

Merged
nulls merged 8 commits intomainfrom
feature/precision_recall#514
May 31, 2022
Merged

save-cli: Precision and recall#395
nulls merged 8 commits intomainfrom
feature/precision_recall#514

Conversation

@nulls
Copy link
Member

@nulls nulls commented May 31, 2022

What's done:

  • added expected and unexpectedMatch to report
  • updated badges in README.md

It's part of saveourtool/save-cloud#514

### What's done:
- added expected and unexpectedMatch to report
- fixed generation of MD file
- updated badges in README.md
@nulls nulls added documentation Improvements or additions to documentation enhancement New feature or request refactoring labels May 31, 2022
@nulls nulls self-assigned this May 31, 2022
@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #395 (d9d3e5e) into main (3aac565) will increase coverage by 0.03%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##               main     #395      +/-   ##
============================================
+ Coverage     47.78%   47.82%   +0.03%     
  Complexity      152      152              
============================================
  Files            46       46              
  Lines          1647     1652       +5     
  Branches        313      313              
============================================
+ Hits            787      790       +3     
- Misses          732      734       +2     
  Partials        128      128              
Flag Coverage Δ
unittests 47.82% <66.66%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tlin/com/saveourtool/save/core/result/DebugInfo.kt 0.00% <0.00%> (ø)
...veourtool/save/plugin/warn/utils/ResultsChecker.kt 61.53% <80.00%> (+2.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3aac565...d9d3e5e. Read the comment docs.

nulls added 5 commits May 31, 2022 14:43
### What's done:
- reverted changes in Generation.kt
### What's done:
- reverted changes in Generation.kt (import)
### What's done:
- fixed build
### What's done:
- added debug to gradle
### What's done:
- fixed method size
@nulls nulls enabled auto-merge (squash) May 31, 2022 12:47
Copy link
Member

@orchestr7 orchestr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nulls nulls disabled auto-merge May 31, 2022 12:56
### What's done:
- renamed unexpectedMatch to unexpected
@nulls nulls enabled auto-merge (squash) May 31, 2022 13:04
@nulls nulls merged commit c85af09 into main May 31, 2022
@nulls nulls deleted the feature/precision_recall#514 branch May 31, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants