Refactoring of gradle scripts to add 'jvm' target to cli#417
Merged
Refactoring of gradle scripts to add 'jvm' target to cli#417
Conversation
- complete refactoring of Gradle scripts
…eature/gradle-refactoring � Conflicts: � save-cli/jvmMain/kotlin/com/saveourtool/save/cli/SaveConfigReader.kt
- complete refactoring of Gradle scripts
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
save-cli/src/nativeMain/kotlin/com/saveourtool/save/cli/FileSystemNative.kt
Fixed
Show fixed
Hide fixed
save-cli/src/nativeMain/kotlin/com/saveourtool/save/cli/FileSystemNative.kt
Fixed
Show fixed
Hide fixed
- complete refactoring of Gradle scripts
save-cli/src/commonNonJsMain/kotlin/com/saveourtool/save/cli/logging/Logger.kt
Fixed
Show fixed
Hide fixed
save-cli/src/nativeMain/kotlin/com/saveourtool/save/cli/logging/Logger.kt
Fixed
Show fixed
Hide fixed
Codecov Report
@@ Coverage Diff @@
## main #417 +/- ##
============================================
- Coverage 48.13% 47.31% -0.82%
Complexity 155 155
============================================
Files 47 51 +4
Lines 1685 1714 +29
Branches 319 321 +2
============================================
Hits 811 811
- Misses 747 776 +29
Partials 127 127
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
- removed "old" binaries
orchestr7
commented
Jun 28, 2022
| @@ -1,10 +1,6 @@ | |||
| // ;warn:1:1 [FILE_NAME_MATCH_CLASS] file name is incorrect - it should match with the class described in it if there is the only one class declared: Example1Expected.kt vs Example{{.*}} | |||
Member
Author
There was a problem hiding this comment.
wow, this is done by build.gradle during test execution
Member
Author
There was a problem hiding this comment.
No, I think it happened because I have interrupted build with ctrl + C
Member
There was a problem hiding this comment.
Yes, but I don't think we touch files with Gradle. It must've been done either by our tests or by save itself
Member
There was a problem hiding this comment.
Shouldn't this change be reverted BTW?
orchestr7
commented
Jun 28, 2022
orchestr7
commented
Jun 28, 2022
save-cli/src/nativeMain/kotlin/com/saveourtool/save/cli/logging/Logger.kt
Show resolved
Hide resolved
- removed "old" binaries
petertrr
reviewed
Jun 29, 2022
- removed "old" binaries
- complete refactoring of Gradle scripts
- removed talaiot
…eature/gradle-refactoring � Conflicts: � build.gradle.kts
orchestr7
commented
Jun 29, 2022
buildSrc/src/main/kotlin/com/saveourtool/save/buildutils/JacocoConfiguration.kt
Show resolved
Hide resolved
buildSrc/src/main/kotlin/com/saveourtool/save/buildutils/JacocoConfiguration.kt
Fixed
Show fixed
Hide fixed
petertrr
approved these changes
Jul 1, 2022
- complete refactoring of Gradle scripts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.