Conversation
### What's done: - Possibly breaking, risky change - Moving App.kt routs to a separate file (initial version) Will be done in 3 phazes
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
ktlint found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
Codecov Report
@@ Coverage Diff @@
## master #1565 +/- ##
============================================
- Coverage 35.73% 35.72% -0.02%
- Complexity 519 520 +1
============================================
Files 234 235 +1
Lines 6416 6422 +6
Branches 656 653 -3
============================================
+ Hits 2293 2294 +1
- Misses 3956 3962 +6
+ Partials 167 166 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
### What's done: - Possibly breaking, risky change - Moving App.kt routs to a separate file (initial version) Will be done in 3 phazes
### What's done: - if method is used inside the transactional, then it should be itself transactional - adding Modifying annotation also to mark delete query
…to feature/first-rework-app
…to feature/first-rework-app � Conflicts: � save-frontend/src/main/kotlin/com/saveourtool/save/frontend/components/views/demo/DiktatDemoView.kt
…to bugfix/propagation-errors
petertrr
reviewed
Dec 17, 2022
| * Just put a map: View -> Route URL to this list | ||
| */ | ||
| val basicRouting: FC<AppProps> = FC { props -> | ||
| val contestView: FC<Props> = withRouter { location, params -> |
Member
There was a problem hiding this comment.
I think all these FCs need to be declared on top level, not inside another FC
Member
Author
There was a problem hiding this comment.
That’s not possible when you have props and need to pass them…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's done:
Will be done in 3 phazes