Skip to content

Comments

[Gradle] Move precompiled script plugins to an included build#948

Merged
petertrr merged 28 commits intomasterfrom
petertrr-patch-1
Dec 7, 2022
Merged

[Gradle] Move precompiled script plugins to an included build#948
petertrr merged 28 commits intomasterfrom
petertrr-patch-1

Conversation

@petertrr
Copy link
Member

@petertrr petertrr commented Jul 20, 2022

When changes are made to code in buildSrc, Gradle re-evaluates the whole build (https://docs.gradle.org/7.5.1/userguide/composite_builds.html, https://docs.gradle.org/7.2/userguide/organizing_gradle_projects.html#sec:build_sources). Putting precompiled plugins in an included build is a new recommedned practice

  • *.gradle.kts moved from buildSrc to gradle/plugins
  • Fixed CLI parameter in workflows
  • VersioningConfiguration is moved and converted. Other files can be moved later
  • Switched back on K/N cache as it seems that it works now

@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #948 (ae0819f) into master (4c99cc6) will decrease coverage by 0.10%.
The diff coverage is n/a.

❗ Current head ae0819f differs from pull request most recent head ca2a02f. Consider uploading reports for the commit ca2a02f to get more accurate results

@@             Coverage Diff              @@
##             master     #948      +/-   ##
============================================
- Coverage     35.33%   35.22%   -0.11%     
+ Complexity      511      510       -1     
============================================
  Files           230      230              
  Lines          6384     6384              
  Branches        644      644              
============================================
- Hits           2256     2249       -7     
- Misses         3963     3972       +9     
+ Partials        165      163       -2     
Impacted Files Coverage Δ
...ve/frontend/components/basic/ManageUserRoleCard.kt 36.36% <0.00%> (-18.19%) ⬇️
...ol/save/orchestrator/service/HeartBeatInspector.kt 71.92% <0.00%> (-1.76%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@petertrr petertrr changed the title WIP check gradle build [Gradle] Move precompiled script plugins to an included build Dec 2, 2022
@petertrr petertrr marked this pull request as ready for review December 7, 2022 06:48
@petertrr petertrr enabled auto-merge (squash) December 7, 2022 09:03
@petertrr petertrr merged commit bc833d9 into master Dec 7, 2022
@petertrr petertrr deleted the petertrr-patch-1 branch December 7, 2022 09:11
petertrr added a commit that referenced this pull request Dec 16, 2022
…pt plugins (#1622)

* Move configuration of diktat, detekt and spotless into `gradle/plugins`

Continuation of #948
petertrr added a commit that referenced this pull request Dec 19, 2022
Configurations for
* Jacoco
* Git hooks
* Publishing
* Disable talaiot metrics that rely on OSHI and JNA

Continuation of #948, #1622
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants