Change semantics of advance! to avoid changing the cursor.#9
Merged
Conversation
The original semantics (leaving the cursor pointing to the end of the stream after raising an error) weren't that useful in practice. It's much more useful to leave the cursor unchanged in the case that `advance!` fails to have enough `bytes_ahead` to move forward by the requested amount, and raises an `error!`. This is a breaking change in the semantics of an existing method, but existing code using this method is not relying on those semantics, so in practice it should not break existing code in known libraries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original semantics (leaving the cursor pointing to the end
of the stream after raising an error) weren't that useful in practice.
It's much more useful to leave the cursor unchanged in the case
that
advance!fails to have enoughbytes_aheadto move forwardby the requested amount, and raises an
error!.This is a breaking change in the semantics of an existing method,
but existing code using this method is not relying on those semantics,
so in practice it should not break existing code in known libraries.