Print root-package relative path of the file where a failure happens#22
Merged
mneumann merged 1 commit intosavi-lang:mainfrom Sep 22, 2022
mneumann:print-rootpkg-relative-path-in-failures
Merged
Print root-package relative path of the file where a failure happens#22mneumann merged 1 commit intosavi-lang:mainfrom mneumann:print-rootpkg-relative-path-in-failures
mneumann merged 1 commit intosavi-lang:mainfrom
mneumann:print-rootpkg-relative-path-in-failures
Conversation
Issue #20 is about printing the absolute path and not the package-relative path as this commit implements. We decided to use the root-package relative path as the absolute path exposes details about where you store your files and also makes the spec for `Spec` itself difficult. The root-package is the one where you are running `savi build` or `savi run` from. Related issues: #20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #20 is about printing the absolute path and not the package-relative path as this commit implements. We decided to use the root-package relative path as the absolute path exposes details about where you store your files and also makes the spec for
Specitself difficult.The root-package is the one where you are running
savi buildorsavi runfrom.This requires savi v0.20220921.1 or later.
Related issues: #20