6️⃣ CHAPTER_06 unit of work #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sawaca96
commented
Jan 23, 2023
Comment on lines
+34
to
+41
| # async sqlalchemy doesn't support relationship | ||
| # It raise 'greenlet_spawn has not been called; can't call await_() here. Was IO attempted in an unexpected place?' # noqa E501 | ||
| result = await self._session.execute( | ||
| sa.select(models.Batch) | ||
| .where(models.Batch.id == id) | ||
| .options(selectinload(models.Batch.allocations)) | ||
| ) | ||
| return result.scalar_one() |
There was a problem hiding this comment.
async sqlalchemy에서 mapping한 객체의 relationship fetch을 지원하지 않아서 execute로 수정했습니다.
| self.eta = eta | ||
| self.purchased_quantity = qty | ||
| self.allocations: set[OrderLine] = set() | ||
| id: UUID = field(default_factory=uuid4) |
There was a problem hiding this comment.
default_factory를 사용하기 위해서 dataclass로 변경했습니다.
모델은 kw_only를 사용하도록 했습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.