decrypt-cookies crate: add iterable ChromiumName and FirefoxName

[emarsden]

In a previous version of this crate, there was a Browser enum that was iterable (thanks to strum) to iterate over all supported browser names. The new FirefoxPath and ChromiumPath traits are not iterable, so crate users need to reproduce the list {Firefox, Floorp, Librewolf, Zen} and keep it up to date with the decrypt-cookies crate.

It would be convenient if the crate provided something like ChromiumName and FirefoxName enums (as implemented in tidy-browser).

[saying121]

I agree. Perhaps adding a function that returns an Iterator<Item = impl chromium::GetCookies> would also be useful.

PRs are welcome.

[emarsden]

Thanks for adding the BROWSERS variable that contains the names of supported browsers.

Unfortunately this is not useful for my use case, which is iterating over all cookies and all supported browsers (I suspect this is not an unusual use case, which is why I raise this again). In a previous crate version, it was possible to do this:

      for browser in Browser::iter() {
            if browser.is_chromium_base() {
                if let Ok(browser) = ChromiumBuilder::new(browser).build().await {
                    if let Ok(cookies) = browser.get_cookies_all().await {
                        info!("  {:?} ({} cookies)", browser.browser(), cookies.len());
                    }
                }
            }
            if browser.is_firefox_base() {
                if let Ok(browser) = FirefoxBuilder::new(browser).build().await {
                    if let Ok(cookies) = browser.get_cookies_all().await {
                        info!("  {:?} ({} cookies)", browser.browser(), cookies.len());
                    }
                }
            }
        }

I have tried to implement similar functionality, but my knowledge of generics and traits is insufficient.

[saying121]

Thanks for adding the BROWSERS variable that contains the names of supported browsers.

Unfortunately this is not useful for my use case, which is iterating over all cookies and all supported browsers (I suspect this is not an unusual use case, which is why I raise this again). In a previous crate version, it was possible to do this:

      for browser in Browser::iter() {
            if browser.is_chromium_base() {
                if let Ok(browser) = ChromiumBuilder::new(browser).build().await {
                    if let Ok(cookies) = browser.get_cookies_all().await {
                        info!("  {:?} ({} cookies)", browser.browser(), cookies.len());
                    }
                }
            }
            if browser.is_firefox_base() {
                if let Ok(browser) = FirefoxBuilder::new(browser).build().await {
                    if let Ok(cookies) = browser.get_cookies_all().await {
                        info!("  {:?} ({} cookies)", browser.browser(), cookies.len());
                    }
                }
            }
        }

I have tried to implement similar functionality, but my knowledge of generics and traits is insufficient.

Let me sort it out.

Your use case is to iterate over supported browsers and perform different operations depending on Firefox or Chromium.

Is it possible to satisfy this use case by adding a manually maintained enumeration and adding a judgment method?

[saying121]

I agree. Perhaps adding a function that returns an Iterator<Item = impl chromium::GetCookies> would also be useful.

PRs are welcome.

By the way, this assumption using impl is wrong, and this trait cannot be used as a dyn

[emarsden]

The use case is to iterate over all supported (and installed) browsers, and extract cookies for them. The per-family (Chromium/Firefox) code above is a detail that was required because they implemented different traits.

The idea is that this should be possible without manually maintaining an enum of supported browsers, that has to be updated whenever the decrypt_cookies crate adds support for a new browser.