Conversation
sbimochan
added
help wanted
|
|
||
| COMMIT_WITH_BRANCH="git commit -m \"$CURRENT_BRANCH: $1\"" | ||
| DEFAULT_COMMIT="git commit -m \"$1\"" | ||
| colorEcho "YELLOW" "Excluding branches from .ignore file." |
There was a problem hiding this comment.
Not sure if we need any of this information.
There was a problem hiding this comment.
Since there’re confusing conditions like default ignoring branches and branches to ignore from .ignore file, I thought user may want to know what commit was really made.
There was a problem hiding this comment.
The use will know from the commit message in the end.
There was a problem hiding this comment.
Yes but making it fancy 🤣
| @@ -1,26 +1,36 @@ | |||
| #!/usr/bin/env bash | |||
| set -euo pipefail | |||
| else | ||
| echo "Commiting with default branch" | ||
| eval $DEFAULT_COMMIT | ||
| colorEcho "GREEN" "Commit translation: \"$1\"" |
There was a problem hiding this comment.
why not move this to a function as well if we're doing it for everything else?
There was a problem hiding this comment.
I don’t think function is needed now. What do you think about colorEcho and function?
There was a problem hiding this comment.
Maybe you should add screenshots to the PR. How it looks now. It's a good idea to get visual feedback with colors on how the commit message has been written
There was a problem hiding this comment.
On the third line of the output you already know if smart-commit was useful or not. Thus, any verbosity is not required. If it was for debugging or anything else, it would have made sense. Keep it simple, it should be fine.
There was a problem hiding this comment.
The coloring is not required in my opinion. What you can do is add an additional flag to show these messages. By default, it should show none.
When current branch is in exclude list:
When current branch is not in exclude list:
|
|
Like @mesaugat said, we don't need the "Excluding branches..." text |
|
@aviskarkc10 okay. sounds great. so only the green part? so that it could highlight what was the message |
|
I am with Saugat dai on the on color thing as well. but doesn't matter to me which way you go. |
|
On a dilemma |
3 participants
set -euo pipefail