This repository was archived by the owner on Jul 24, 2023. It is now read-only.
Added PyCode_NewEmpty binding.#19
Closed
eliothedeman wants to merge 5 commits intosbinet:masterfrom
Closed
Conversation
Owner
|
LGTM, modulo the little typo :) |
Owner
There was a problem hiding this comment.
ah. I think you need to free the CStrings (otherwise: memory leaks)
ie:
cfname := C.CString(filename)
defer C.free(unsafe.Pointer(cfname))
cfuncname := C.CString(funcname)
defer C.free(unsafe.Pointer(cfuncname))
return togo(...)
Contributor
Author
|
Yup, forgot to free... my bad. |
Owner
|
thanks. could you address the little typo in the docstring ? |
Contributor
Author
|
Yeah sorry about the trouble. I hope to keep helping, just wanted to get my feet wet first. |
Owner
|
no worries, and thanks again. |
Owner
|
ok, I cleaned up a bit your code and sent #20 next time, could you create a branch and send the pull request from that branch instead of from your |
Contributor
Author
|
ahh yes, will do. Sorry |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.