Fix NPE in ExpandFunctionDefinitionConverter for getDerivedUnits (issue #268)#279
Open
dyrpsf wants to merge 1 commit intosbmlteam:masterfrom
Open
Fix NPE in ExpandFunctionDefinitionConverter for getDerivedUnits (issue #268)#279dyrpsf wants to merge 1 commit intosbmlteam:masterfrom
dyrpsf wants to merge 1 commit intosbmlteam:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #268.
Calling
AssignmentRule.getDerivedUnits()on the rule for variablejaplin BIOMD0000000327.xml previouslyresulted in a
NullPointerExceptionduring function definition expansion.Root cause
ExpandFunctionDefinitionConverter.replaceAll(...)walks the AST and,for each occurrence of a bound variable
bvar, retrievescurrent.getParent()and casts it directly toASTNode.getDerivedUnits()triggers expansion), the parent of thematching node is
nullor not anASTNode, which leads to an NPE when callingparent.getIndex(current).Changes
Updated
replaceAll(ASTNode newMath, ASTNode bvar, ASTNode expandedBVar)to guard against null / non-ASTNodeparents:
This keeps the existing behavior for all valid parent–child relationships, but avoids dereferencing null or non-ASTNode parents.
Tests
Loads the example model BIOMD0000000327.xml (added under core/test/org/sbml/jsbml/testdata/).
Locates the AssignmentRule with variable "japl".
Asserts that rule.getDerivedUnits() does not throw a NullPointerException.
Both complete with BUILD SUCCESS on Java 11.