Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Docker build process to properly set the application version. It introduces a VERSION build argument in the Dockerfile that overrides the version in pyproject.toml, and modifies the GitHub Actions workflow to use a simpler versioning scheme for branch builds (using only the short SHA instead of branch-shortsha format).
Changes:
- Added
VERSIONbuild argument to Dockerfile with a default value of "dev" - Implemented version override in
pyproject.tomlduring Docker build using sed - Simplified branch build versioning to use only short SHA instead of branch name plus short SHA
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Dockerfile | Adds VERSION build arg and sed command to override version in pyproject.toml |
| .github/workflows/sbomify.yaml | Simplifies branch versioning to use only short SHA |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
* Add valid placeholder value
* Set valid placeholder
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Override version to match intended build in Docker