Skip to content

Set the correct version#120

Merged
vpetersson merged 4 commits intomasterfrom
fix-version-in-action
Jan 16, 2026
Merged

Set the correct version#120
vpetersson merged 4 commits intomasterfrom
fix-version-in-action

Conversation

@vpetersson
Copy link
Contributor

Override version to match intended build in Docker

Copilot AI review requested due to automatic review settings January 16, 2026 19:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Docker build process to properly set the application version. It introduces a VERSION build argument in the Dockerfile that overrides the version in pyproject.toml, and modifies the GitHub Actions workflow to use a simpler versioning scheme for branch builds (using only the short SHA instead of branch-shortsha format).

Changes:

  • Added VERSION build argument to Dockerfile with a default value of "dev"
  • Implemented version override in pyproject.toml during Docker build using sed
  • Simplified branch build versioning to use only short SHA instead of branch name plus short SHA

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
Dockerfile Adds VERSION build arg and sed command to override version in pyproject.toml
.github/workflows/sbomify.yaml Simplifies branch versioning to use only short SHA

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

* Add valid placeholder value
* Set valid placeholder
Copilot AI review requested due to automatic review settings January 16, 2026 20:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@vpetersson vpetersson merged commit 52ae24f into master Jan 16, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant