Fix Sentry filtering for log-based configuration errors#152
Merged
vpetersson merged 1 commit intomasterfrom Jan 28, 2026
Merged
Fix Sentry filtering for log-based configuration errors#152vpetersson merged 1 commit intomasterfrom
vpetersson merged 1 commit intomasterfrom
Conversation
The before_send filter was only filtering exceptions (checking for exc_info), but configuration errors logged via logger.error() bypass exception filtering since they come through the logging integration. Now also filters log events where the message starts with "Configuration error:". Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
before_sendSentry filter to also filter log-based eventslogger.error()were bypassing the exception filter since they come through the logging integration (noexc_info)Test plan
test_sentry_filters_configuration_error_log_messagescovering bothmessageandlogentry.formattedformatsuv run pytest tests/test_sentry_filtering.py -v🤖 Generated with Claude Code