Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves version handling by introducing an environment variable-based versioning system for Docker releases and updates documentation formatting for better clarity.
Key Changes:
- Adds environment variable-based version detection as the primary method for getting package version
- Updates README table formatting to use clearer footnote symbols
- Configures Docker build to pass version information via build arguments
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| sbomify_action/cli/main.py | Adds environment variable check as the primary version detection method with updated priority documentation |
| README.md | Updates table footnote symbols from asterisks to daggers/double daggers for improved clarity |
| Dockerfile | Adds environment variables to capture version metadata from build arguments |
| .github/workflows/sbomify.yaml | Implements version determination logic and passes build arguments to Docker build |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor changes to improve version handling