fix: skip redundant component name override when name already matches#94
Merged
vpetersson merged 1 commit intomasterfrom Jan 7, 2026
Merged
fix: skip redundant component name override when name already matches#94vpetersson merged 1 commit intomasterfrom
vpetersson merged 1 commit intomasterfrom
Conversation
The component name override logic was running in both Step 1 (_apply_sbom_name_override in main.py) and Step 2 (augment_sbom in augmentation.py), causing duplicate log messages like: 'github.com/aquasecurity/trivy' -> 'Trivy' (Step 1) 'Trivy' -> 'Trivy' (Step 2 - redundant) Now both locations check if existing_name != component_name before applying the override and logging. Also optimized main.py to skip file serialization when no change is needed.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR eliminates redundant component name override operations and log messages that were occurring when the component name already matched the target value. The fix addresses duplicate logging across two steps of the SBOM processing pipeline by adding conditional checks before applying overrides.
Key Changes:
- Added conditional checks to skip name override when existing name matches target name
- Optimized file serialization to only occur when actual changes are made
- Consolidated logging to only output when overrides are actually applied
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| sbomify_action/cli/main.py | Added conditional checks and needs_update flag to skip redundant CycloneDX and SPDX name overrides and avoid unnecessary file serialization |
| sbomify_action/augmentation.py | Added conditional check to prevent redundant component name overrides in CycloneDX augmentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The component name override logic was running in both Step 1 (_apply_sbom_name_override in main.py) and Step 2 (augment_sbom in augmentation.py), causing duplicate log messages like:
'github.com/aquasecurity/trivy' -> 'Trivy' (Step 1)
'Trivy' -> 'Trivy' (Step 2 - redundant)
Now both locations check if existing_name != component_name before applying the override and logging. Also optimized main.py to skip file serialization when no change is needed.