Add strict browser wrappers for window timers and navigator share#33
Merged
sbsoftware merged 11 commits intoreleases/v1.8.0from Feb 19, 2026
Merged
Add strict browser wrappers for window timers and navigator share#33sbsoftware merged 11 commits intoreleases/v1.8.0from
sbsoftware merged 11 commits intoreleases/v1.8.0from
Conversation
sbsoftware
reviewed
Feb 18, 2026
sbsoftware
reviewed
Feb 19, 2026
sbsoftware
reviewed
Feb 19, 2026
sbsoftware
reviewed
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds typed browser context wrappers for
windowtimers andnavigator.shareso strict-mode snippets can use real browser globals without_literal_js.Changes
JS::Context::Windowwith:setTimeout(callback, delay)returning a typedJS::Context::TimerHandleclearTimeout(handle)accepting that typed handleJS::Context::Navigator#sharewith typed named args:texttitleandurlJS::Context::ShareDatato emit the share payload object literal.JS::Context::Browser:windownavigatorwindow.setTimeout+window.clearTimeout)navigator.share)to_js_refoutputTesting
CRYSTAL_CACHE_DIR=/tmp/.crystal-cache-js crystal spec53 examples, 0 failures, 0 errors, 0 pending